Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIMS-2028 Readme Updates #2696

Merged
merged 6 commits into from
Sep 23, 2024
Merged

PIMS-2028 Readme Updates #2696

merged 6 commits into from
Sep 23, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-2028

Changes

  • Updated root README
  • Updated READMEs for react-app and express-api
  • Updated .env-template
  • Removed old files from root related to gitattributes and prettier

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Sep 23, 2024
@github-actions GitHub Actions
Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2696. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@github-actions GitHub Actions
Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2696. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

LawrenceLau2020
LawrenceLau2020 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated docs look good! Restoring the .gitattributes file seems to resolve the line feed error I was getting in Windows. No errors any more.

@dbarkowsky dbarkowsky merged commit 1f896e2 into main Sep 23, 2024
11 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-2028-Readme-Updates branch September 23, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LawrenceLau2020 LawrenceLau2020 LawrenceLau2020 approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@dbarkowsky dbarkowsky

Labels
Documentation Express React
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbarkowsky @LawrenceLau2020